Skip to content

[3/N] Refine beginner tutorial by accelerator api #3170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 24, 2025
Merged

[3/N] Refine beginner tutorial by accelerator api #3170

merged 4 commits into from
Jan 24, 2025

Conversation

guangyey
Copy link
Contributor

@guangyey guangyey commented Nov 27, 2024 •
edited
Loading

For #3113

Motivation

As titled, we aim to use accelerator API to refine the beginner model tutorial to make it device-agnostic.

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 27, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3170

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

albanD
albanD reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.
Will let @svekars take a final look.

@svekars svekars added skip-link-check Will allow you to skip linkcheck on a PR. Should only should be used when a link can't be fixed. 2.6 Tracking 2.6 version PRs. labels Dec 2, 2024
@svekars svekars changed the base branch from main to 2.6-RC-TEST December 20, 2024 19:08
@svekars svekars changed the base branch from 2.6-RC-TEST to main December 20, 2024 21:11
@svekars svekars merged commit c2faee4 into pytorch:main Jan 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD left review comments

Assignees
No one assigned
Labels
2.6 Tracking 2.6 version PRs. cla signed skip-link-check Will allow you to skip linkcheck on a PR. Should only should be used when a link can't be fixed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guangyey @albanD @svekars @facebook-github-bot